Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redigo to v1.8.9 #83

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Update redigo to v1.8.9 #83

merged 1 commit into from
Jul 24, 2023

Conversation

ripexz
Copy link
Contributor

@ripexz ripexz commented Jul 19, 2023

v2.0.0+incompatible has been retracted as it was released by accident, see gomodule/redigo#590

Since redigo v2.0.0 was not properly set up with go modules and doesn't have /v2 path it makes it impossible to upgrade redigo version for your package if it also depends on go-health.

@ripexz ripexz requested a review from a team as a code owner July 19, 2023 07:17
@ripexz
Copy link
Contributor Author

ripexz commented Jul 24, 2023

Hey @chesleybrown @chrisfjones @maxcnunes - not sure if you guys have time to maintain this or who is in @InVisionApp/architecture team, but it would be great to sort this one out.

Copy link
Contributor

@chesleybrown chesleybrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution!

@ripexz
Copy link
Contributor Author

ripexz commented Jul 24, 2023

Looks good! Thank you for the contribution!

Thanks, if you or one of your colleagues could merge and release a new tag, that would be great, cheers! 🎉

@chesleybrown chesleybrown merged commit b1b3f0a into InVisionApp:master Jul 24, 2023
5 checks passed
@chesleybrown
Copy link
Contributor

Published here: https://github.com/InVisionApp/go-health/releases/tag/v2.1.4

@ripexz ripexz deleted the redigo branch July 24, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants