This repository has been archived by the owner on Aug 19, 2018. It is now read-only.
Mitigate against a late CompleteMovement retry which is a Bad Thing #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs up This request is handled with PacketHandlingDisposition.HandleSynchronized however it has an async section at the end, and no protection from queuing up the duplicate request for serial processing once the first call is complete. We're tracking AgentInRegion status here so just avoid resetting it at the start, and instead, use it to recognize the duplicate.
appurist
changed the title
…ng AgentInRegion changed So let's also move the log report outside so that the duplicate and status is recorded.
kf6kjg
approved these changes
Feb 18, 2018
There was a problem hiding this comment.
Looks good to me. I've confirmed that all full assignments to AgentInRegion are to .None, which being the "0" case would be default anyway, and that there are only two calls to CompleteMovement: a direct call in BotManager.cs:278 and as a handler for the client's OnCompleteMovementToRegion event.
|
I've done the practical run-time tests as well now, with breakpoints, delays etc. and confirmed it is coming in as None and should not be anything but, unless it's a (previously destructive) redundant duplicate call already processed (or still being finished in the async part). Thanks for the quick review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may resolve a large number of "login-status-is-completely-screwed" cases, as well as Mantis #3287. This
CompleteMovementrequest is handled withPacketHandlingDisposition.HandleSynchronizedhowever it has an async section at the end, and no protection from queuing up the duplicate request for serial processing once the first call is complete. We're trackingAgentInRegionstatus here so just avoid resetting it at the start, and instead, use it to recognize the duplicate.