Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop ud from default exports of classes #910

Merged
merged 1 commit into from
May 30, 2023
Merged

chore: drop ud from default exports of classes #910

merged 1 commit into from
May 30, 2023

Conversation

wegry
Copy link
Contributor

@wegry wegry commented May 25, 2023

Eases porting class based code to TS.

@wegry wegry requested a review from Macil May 25, 2023 12:07
@wegry wegry self-assigned this May 25, 2023
@Macil
Copy link
Member

Macil commented May 26, 2023

I posted about a solution for #906 in that thread that's not ud-related, so we shouldn't treat this issue as related to it now.

I'm not a big fan of completely purging ud from the codebase. The InboxSDK doesn't have hot-reloading support right now since the move to Webpack but I would like for us to get that back at some point. My comments about ud before about it being removable were mainly meant about if it gets in the way anywhere, like how in Typescript it doesn't properly pass through the types of ud-wrapped classes. I would be interested in this PR if it only removed ud from being used with classes, but kept it in other places like around functions and page-parser-tree options.

Makes the move to TS simpler
@wegry
Copy link
Contributor Author

wegry commented May 26, 2023

I posted about a solution for #906 in that thread that's not ud-related, so we shouldn't treat this issue as related to it now.

@Macil Description updated

I would be interested in this PR if it only removed ud from being used with classes, but kept it in other places like around functions and page-parser-tree options.

8efc33c does just that. For simplicity's sake, only /defn\([A-Z]\w+)/ ud usages are removed.

@wegry wegry changed the title chore: drop ud and ud-kefir chore: drop ud from default exports of classes May 26, 2023
@wegry wegry mentioned this pull request May 26, 2023
@wegry wegry merged commit 26aee53 into main May 30, 2023
6 checks passed
@wegry wegry deleted the chore/drop-ud branch May 30, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants