chore: move a few more files to TS #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegry
commented
Jun 6, 2023
src/platform-implementation-js/dom-driver/gmail/gmail-butter-bar-driver.ts
Outdated
Show resolved
Hide resolved
src/platform-implementation-js/dom-driver/gmail/gmail-driver/get-native-nav-item.ts
Outdated
Show resolved
Hide resolved
wegry
commented
Jun 6, 2023
…et-native-nav-item.ts
Macil
reviewed
Jun 6, 2023
Macil
reviewed
Jun 6, 2023
src/platform-implementation-js/dom-driver/gmail/gmail-driver/user-info.ts
Outdated
Show resolved
Hide resolved
Macil
approved these changes
Jun 6, 2023
wegry
commented
Jun 7, 2023
dmy7r0
approved these changes
Jun 7, 2023
wegry
added a commit
that referenced
this pull request
Jun 12, 2023
wegry
added a commit
that referenced
this pull request
Jun 12, 2023
types: relax ButtonDescriptor type made too strict in #913
wegry
added a commit
that referenced
this pull request
Jun 23, 2023
chore: drop unused variables left over from #913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves some more files over to TS from Flow (syntactically),
platform-implementationandcompose-viewbeing the biggest two. I suggest ignoring whitespace changes. To reduce noise, there should be no runtime changes. If you see any, please flag them.Most ESLint rules have been disabled where they conflict for newly moved Flow to TS files for the sake of noise.
One exception isMoved to #916. A subsequent pass to remove file wideprefer-constautofixed in a few spots.@typescript-eslint/no-unused-variablesdisabling might flesh out a good chunk of dead code in the form of unused imports.Other bits:
Kefir.later(n)has been rendered asKefir.later(n, undefined)to match the TS Kefir types.flow checkhas been removed.js.flowfiles have been removed. This is roughly 1/3 of the files touched in the PR.getEventStreammethods on views tend to be loosely typed and should be tightened over time.