Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dependency on the English language #28

Closed
2 tasks done
IncPlusPlus opened this issue Aug 22, 2021 · 0 comments · Fixed by #148
Closed
2 tasks done

Avoid dependency on the English language #28

IncPlusPlus opened this issue Aug 22, 2021 · 0 comments · Fixed by #148
Assignees
@IncPlusPlus
Milestone
2.0.1

Comments

@IncPlusPlus
Copy link
Owner

IncPlusPlus commented Aug 22, 2021 •
edited
Loading

Right now some string scanning is done for English (example here). This issue will exist until that dependency is no longer required.
@IncPlusPlus IncPlusPlus self-assigned this Aug 22, 2021
IncPlusPlus added a commit that referenced this issue Aug 24, 2021
@IncPlusPlus
Added a GameMode enum
e420b6e 
This helps with determining the current game mode without relying on English being the primary language (as planned in #28)
@IncPlusPlus IncPlusPlus added this to the 2.0.1 milestone Oct 16, 2021
@IncPlusPlus IncPlusPlus mentioned this issue Oct 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IncPlusPlus IncPlusPlus

Labels
None yet
Projects
None yet
Milestone
2.0.1
Development

Successfully merging a pull request may close this issue.

Stop depending on strings to be in English IncPlusPlus/titanfall2-rp
1 participant
@IncPlusPlus