-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some opt-out telemetry #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c10c62
to
b180226
Compare
a9e0016
to
a630413
Compare
This is an open source project. People might take issue with even the slightest bit of telemetry so I'll allow them to opt out.
This reverts commit 92ce7dfea35ed8719db553abe4724678dd7c01f8. I changed my mind about how this will be implemented. It'd be easier if it were inside the titanfall2-rp project.
fml
This is to try and fix the issue where as you're connecting to a match, your presence may briefly say "Main Menu". I have no idea why this is.
As it turns out, the multiplayer lobby isn't something that fits the gamemode and map name regex. Who woulda thunk it?!
a630413
to
e1d14f4
Compare
I accidentally left notepad as the only application that'd be launched whether you wanted to edit OR be shown a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little bit of telemetry. This helps me know if the software is working right and if there are any errors people are having. If you're not comfortable with this, you can feel free to opt out of it in the settings.