Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals are not inherited in the subtype namespace #50

Open
gbatori1 opened this issue Sep 10, 2015 · 1 comment
Open

Signals are not inherited in the subtype namespace #50

gbatori1 opened this issue Sep 10, 2015 · 1 comment

Comments

@gbatori1
Copy link
Collaborator

Example from PhoneX:
In Subscriber class there are many Signals are defined. For example, CallAccepted signal cannot be used as the member of the Caller class (with the Caller namespace) so the following line results in validation error:
send new Caller::CallAccepted() to caller;

The User is forced to write:
send new Subscriber::CallAccepted() to caller;

@ujhelyiz
Copy link
Member

Our solution was based on similar ideas as static method calls: in Java you can call a static method from a base class, but a warning is reported as it is not recommended. I guess, the Signals are similar in this aspect: even if you are calling them from the descendant class, you want to use exactly the same as base version, and this way there is no surprise where you should look for the original definition.

May I ask the rationale behind this requirement? Maybe I am missing something here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants