Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

.htaccess <IfModule> issue #18

Closed
durzel opened this issue Feb 8, 2016 · 2 comments
Closed

.htaccess <IfModule> issue #18

durzel opened this issue Feb 8, 2016 · 2 comments

Comments

@durzel
Copy link
Contributor

durzel commented Feb 8, 2016

Minor thing this, only noticed it today. The .htaccess that ships with Magento 1.x includes a set of PHP settings that will be ignored by an install running PHP 7.x.

This is because they are contained within an <IfModule mod_php5.c> declaration.

The simple fix for this is to change it to <IfModule mod_php7.c>. Assuming no other incompatible changes have been made to the content of this block, there are no issues.

This is fairly important because one of the things added in this block by default is:

php_value memory_limit 256M
php_value max_execution_time 18000

..which will be ignored without this change.

Do you think this is important enough to be included in this modul

@icurdinj
Copy link
Contributor

icurdinj commented Feb 9, 2016

This is true, and quite important on setups which use mod_php. Most production sites don't, but many development localhosts do. I don't think we can "patch" .htaccess from the module itself, but we can document this in readme file, just to remind users.

@durzel
Copy link
Contributor Author

durzel commented Feb 11, 2016

Cool, that'll work 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants