-
Notifications
You must be signed in to change notification settings - Fork 114
Firegento doesn't update with new releases #35
Comments
@icurdinj The Firegento repository is a Satis repository. As such, it follows the rules outlined here: https://getcomposer.org/doc/02-libraries.md#tags with regard to picking up on valid version numbers. The current tag naming scheme for this project, You might also consider splitting this project into separate repos or branches to distinguish between the CE/EE versions of the module. This would eliminate the need for tag prefixes/suffixes. TL;DR: Beginning the git tags with |
@icurdinj I just tried to pull your If you want releases to show up in a satis repository, it looks like you must be very conservative in your tag naming. Any git tag prefix/suffix beyond what is explicitly listed in the documentation will result in the tag not counting as a "release". IMO, the best way to proceed from here is the split repo approach. One repo for the CE version, and one repo for the EE version. In the split-repo layout, a Magento CE user might specify in their composer.json: "require": {
"inchoo/php7-ce": "^1.0.4"
} Whereas the Magento EE user would do this: "require": {
"inchoo/php7-ee": "^1.0.4"
} This would allow you to have the same tag names for each CE/EE release (in addition to properly-named tags for the satis repo.). |
Thank you very much @t-richards for all the information and effort. Since the difference between CE and EE versions is very small, and it is very convenient to keep everything in one repository and just 2 branches, I finally decided to make a simple "1.0.3" release of master branch, which is for CE and should show up on Firegento. EE version will just have to be installed from "dev-EE" version/branch, at least for the time being. |
The |
Don't know why, have to investigate... If anyone has more experience with Firegento and an idea why this happens, help is always welcome.
The text was updated successfully, but these errors were encountered: