Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Firegento doesn't update with new releases #35

Closed
icurdinj opened this issue Apr 24, 2016 · 4 comments
Closed

Firegento doesn't update with new releases #35

icurdinj opened this issue Apr 24, 2016 · 4 comments

Comments

@icurdinj
Copy link
Contributor

Don't know why, have to investigate... If anyone has more experience with Firegento and an idea why this happens, help is always welcome.

@t-richards
Copy link

t-richards commented Apr 26, 2016

@icurdinj The Firegento repository is a Satis repository. As such, it follows the rules outlined here: https://getcomposer.org/doc/02-libraries.md#tags with regard to picking up on valid version numbers.

The current tag naming scheme for this project, CE-X.Y.Z or EE-X.Y.Z -- these do not match any of the formats outlined in the documentation. A more appropriate tag naming scheme for composer compatibility might be something like vX.Y.Z-CE or vX.Y.Z-EE.

You might also consider splitting this project into separate repos or branches to distinguish between the CE/EE versions of the module. This would eliminate the need for tag prefixes/suffixes.

TL;DR: Beginning the git tags with CE- is almost certainly the cause of this problem. Try using a version number, then a suffix (e.g. v1.0.2-CE), instead of the other way around.

@t-richards
Copy link

t-richards commented Apr 27, 2016

@icurdinj I just tried to pull your 1.0.3-CE tag into my private satis repo, but it didn't show up in the releases section. Additionally, I created a test repo and tried a few variations of tags which included CE in them, and none of them counted as "releases" in the eyes of Satis/Composer.

If you want releases to show up in a satis repository, it looks like you must be very conservative in your tag naming. Any git tag prefix/suffix beyond what is explicitly listed in the documentation will result in the tag not counting as a "release".

IMO, the best way to proceed from here is the split repo approach. One repo for the CE version, and one repo for the EE version.

In the split-repo layout, a Magento CE user might specify in their composer.json:

"require": {
  "inchoo/php7-ce": "^1.0.4"
}

Whereas the Magento EE user would do this:

"require": {
  "inchoo/php7-ee": "^1.0.4"
}

This would allow you to have the same tag names for each CE/EE release (in addition to properly-named tags for the satis repo.).

@icurdinj
Copy link
Contributor Author

Thank you very much @t-richards for all the information and effort. Since the difference between CE and EE versions is very small, and it is very convenient to keep everything in one repository and just 2 branches, I finally decided to make a simple "1.0.3" release of master branch, which is for CE and should show up on Firegento. EE version will just have to be installed from "dev-EE" version/branch, at least for the time being.
At least it's better for CE users, while being the same as it was for EE users and contributing developers, so I guess it's some small progress after all.

@t-richards
Copy link

The 1.0.3 tag looks good to me. It shouldn't be too much longer before it appears on the Firegento repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants