cadence 1.0 upgrade

[dryruner]

No description provided.

[joshuahannan]

Just reviewed some of the contracts that looked like they were important. I didn't get to any of the transactions yet. Can you do two things before we review any more of your code?

• Check out the comment that I made about entitlements and make sure that you've gone through all your code in the four PRs you shared with us and added entitlements to all the functions that need them.
• In each PR, let us know which contracts are yours that need our review. It was not clear in this PR which contracts that I should review and which were just dependencies that you have no control over

Thank you!

[dryruner]

Hello @joshuahannan Please take another look! Updated according to your comments and applied correct auth model.

In-Scope:

• src/*.cdc; excluding src/env/* and src/tokens/* as those are all dependencies (FT standards, dummy tokens, blocto code, etc.)

[joshuahannan]

What about all of the swap pair contracts? Those all seem to be copies of each other with just a new names changed, so can we just review one of them and you can propagate all the changes to the others?

[dryruner]

What about all of the swap pair contracts? Those all seem to be copies of each other with just a new names changed, so can we just review one of them and you can propagate all the changes to the others?

Yes all will be upgraded with the same template file.

[joshuahannan]

Great, which template file should we be reviewing? Also, can you go through the other PRs and make sure the entitlements are correct and provide the same guidance for all the other PRs you asked us to review concerning which contracts to review and which to pass on? Let us know in a comment on each PR when that is ready

[dryruner]

template file

The template file is SwapPair.cdc

make sure the entitlements are correct

Yeah for sure, working on that and will inform you once done, thanks for the review!