Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting & run linter in CI #57

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Fix linting & run linter in CI #57

merged 1 commit into from
Jun 22, 2021

Conversation

cgewecke
Copy link
Contributor

The linter's --fix has been mangling the code here (e.g re-writing the files incorrectly).

This makes linting a very annoying manual process people sometimes skip by committing with the --no-verify flag.

The underlying problem is an older version of ganache somewhere deep in the dependency tree which corrupts the source maps. (See ganache-core 879). This can be fixed by coercing the resolved version to latest using yarn resolutions in package.json. (We don't actually use ganache in this project.)

Think this might also resolve a problem where stack traces have incorrect line numbers (have seen this occasionally)

Have also:

  • linted unlinted files
  • updated tslint and tslint-eslint-rules to latest
  • added a lint step to the CI build job so lint failures get caught

@cgewecke cgewecke merged commit 21013c9 into master Jun 22, 2021
@cgewecke cgewecke deleted the chris/update-linter branch June 22, 2021 21:23
ace3 pushed a commit to ace3/index-coop-smart-contracts that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants