Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the introduction Section when a -st is initiated and added functionality '-v' to check the version #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

farseenmanekhan1232
Copy link

Describe the changes you've made

I have added an extra functionality "dynamic -v" to show the version
I have tried to Change the Intro Section of the Dynamic CLI to look and feel like a NPM Package

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Screenshots

"dynamic -v " support
Screenshot from 2021-04-08 23-38-23

Changes in the intro section
Screenshot from 2021-04-08 23-41-53

@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Congratulations!!🎉 for making your first PR , our mentors will review it soon.

Copy link
Contributor

@lainq lainq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good . But you may capitalize the sentences from lines 52-58(main.py)

main.py Show resolved Hide resolved
Copy link
Member

@GouravSardana GouravSardana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize those words

\U0001F609 See this message again with '-st'
\U00002755 Get help with '-h'
Use the following commands to get started
\U0001F50E to search StackOverflow, type 'dynamic -s'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the Indentation of words for the user to read!

Example:

\U0001F50E to search StackOverflow, type 'dynamic -s'

can be replaced by

\U0001F50E To Search on StackOverflow, type 'dynamic -s'

And, similar till #L58

''')
else:
search_flag.search_args()
search_flag.search_args()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add End of file (EOF)

Just Press Enter Once After #L61

Copy link
Contributor

@lainq lainq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you converted the sentences into lower case 🤔 . And also please resolve the merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants