-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made relevant questions visible and their answers viewable. Fixed the red line issue. #82
Made relevant questions visible and their answers viewable. Fixed the red line issue. #82
Conversation
@Siddhant-K-code I have made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not that important but would be good if you can: Grammatical, Spelling errors
1 example is given, you can do similar changes for all docstrings
src/arguments/utility.py
Outdated
|
||
3) Use the data received from the above request and loop | ||
through it to print the answer | ||
1) Gets the details of all the relavant question and stores their title, link and id in "question_data" list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relavant question = > relevant questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will run the code through spell check once.
Kudos, SonarCloud Quality Gate passed! |
@Siddhant-K-code I have checked the spellings and corrected grammatical mistakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work 🎉
Thanks @NamamiShanker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice work
@NamamiShanker Why this is conflicting with the promt-toolkit version of mine?
We are not using promt-kit but still it is conflicting with the promtkit |
|
@GouravSardana Can you please send a screenshot? In my case it is just showing the most upvoted answer. |
What is your prompt toolkit version? I think it might be occurring either because I am using a different method to print red lines or I am clearing terminal with os module. |
Mine is the latest 3.0.18 |
Search for variable and tag is python |
Ok I'll look into it. Are the red lines appearing properly? |
Do you mean it is showing so many questions related to the search? All the 30 questions are being displayed on the screen. |
Nops. It is displaying Answer 1 but all the comments are displaying i.e all upvoted in the answer |
To give you more content - See this - https://stackoverflow.com/questions/986006/how-do-i-pass-a-variable-by-reference This is the first answer link and in this 6-7 comments are there with different upvotes. All are showing |
|
I updated my prompt-toolkit version to 3.0.18 and everything is still working, If the issue continues can we meet on discord or somewhere to resolve it? |
Ohh okay.. can we meet on discord because everything is working alright in my system. No prompt-toolkit error, no comments are visible and quit is also working. |
We can set up a call. Please email your availability at ping@iosf.in |
@GouravSardana I emailed you from namami2011@gmail.com |
Can other member of the org. can also get this |
Hey @GouravSardana! Why was I given 0 points for this merge? |
Related Issue
Closes: #33
Describe the changes you've made
I have made some big changes in the code. The user will now be shown all the relevant question. He will be able to view answer to any one of those questions by inputting question number. Also the issue of red line has been fixed. The line now is very defined and clear with properly formatted content on the screen. Also added automatic caching of requested answers for better performance.
Checklist:
Screenshots
Here is the CLI in action
Looks cool right? I have some more plans for changes further.