Skip to content

Commit

Permalink
fix: get unit tests passing
Browse files Browse the repository at this point in the history
Signed-off-by: Micah Peltier <micah6_8@yahoo.com>
  • Loading branch information
mepeltier committed Jun 3, 2024
1 parent 4e7fc62 commit 3b0c966
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 18 deletions.
4 changes: 0 additions & 4 deletions aries_cloudagent/didcomm_v2/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
from .adapters import ResolverAdapter, SecretsAdapter


__all__ = ["ResolverAdapter", "SecretsAdapter"]
2 changes: 1 addition & 1 deletion aries_cloudagent/didcomm_v2/adapters.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from didcomm_messaging import SecretsManager
from didcomm_messaging.crypto.backend.askar import AskarSecretKey
from didcomm_messaging.resolver import DIDResolver as DMPResolver
except ImportError as err:
except ModuleNotFoundError as err:
raise ImportError("Install the didcommv2 extra to use this module.") from err

from ..core.error import BaseError
Expand Down
9 changes: 6 additions & 3 deletions aries_cloudagent/messaging/v2_agent_message.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
from uuid import uuid4

from .base_message import BaseMessage, DIDCommVersion
from .models.base import BaseModel


class V2AgentMessage(BaseMessage):
"""DIDComm V2 message base class."""

def __init__(self, message, *args, **kwargs):
"""Initialize a v2 agent message instance."""
super().__init__(*args, **kwargs)
self.message = message
self.msg_format = DIDCommVersion.v2
if not "id" in self.message:
if "id" not in self.message:
self.message["id"] = str(uuid4())

@property
Expand All @@ -33,12 +33,15 @@ def _thread_id(self):
return self.message.get("thid", self.message.get("id"))

def serialize(self, msg_format: DIDCommVersion = DIDCommVersion.v1) -> dict:
"""Serialize a message."""
return self.message

def deserialize(cls, value: dict, msg_format: DIDCommVersion = DIDCommVersion.v2):
def deserialize(self, value: dict, msg_format: DIDCommVersion = DIDCommVersion.v2):
"""Deserialize a message."""
self.message = value
self.msg_format = msg_format

@property
def Handler(self):
"""Message handler."""
return None
20 changes: 10 additions & 10 deletions aries_cloudagent/transport/tests/test_pack_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from ...wallet.key_type import ED25519
from .. import pack_format as test_module
from ..error import RecipientKeysError, WireFormatEncodeError, WireFormatParseError
from ..pack_format import PackWireFormat
from ..pack_format import V1PackWireFormat


class TestPackWireFormat(IsolatedAsyncioTestCase):
Expand All @@ -37,7 +37,7 @@ def setUp(self):
self.wallet = self.session.inject(BaseWallet)

async def test_errors(self):
serializer = PackWireFormat()
serializer = V1PackWireFormat()
bad_values = [None, "", "1", "[]", "{..."]

for message_json in bad_values:
Expand All @@ -62,7 +62,7 @@ async def test_errors(self):
await serializer.parse_message(self.session, json.dumps(x_message))
assert "Message JSON parsing failed" in str(context.exception)

serializer = PackWireFormat()
serializer = V1PackWireFormat()
serializer.task_queue = None
with mock.patch.object(
serializer, "unpack", mock.CoroutineMock()
Expand All @@ -78,7 +78,7 @@ async def test_errors(self):
)

async def test_pack_x(self):
serializer = PackWireFormat()
serializer = V1PackWireFormat()

with self.assertRaises(WireFormatEncodeError):
await serializer.pack(self.session, None, None, None, None)
Expand Down Expand Up @@ -113,7 +113,7 @@ async def test_pack_x(self):
await serializer.pack(session, None, ["key"], ["key"], ["key"])

async def test_unpacked(self):
serializer = PackWireFormat()
serializer = V1PackWireFormat()
message_json = json.dumps(self.test_message)
message_dict, delivery = await serializer.parse_message(
self.session, message_json
Expand All @@ -124,7 +124,7 @@ async def test_unpacked(self):
assert delivery.direct_response_mode == "all"

async def test_fallback(self):
serializer = PackWireFormat()
serializer = V1PackWireFormat()

message = self.test_message.copy()
message.pop("@type")
Expand All @@ -140,7 +140,7 @@ async def test_encode_decode(self):
local_did = await self.wallet.create_local_did(
method=SOV, key_type=ED25519, seed=self.test_seed
)
serializer = PackWireFormat()
serializer = V1PackWireFormat()
recipient_keys = (local_did.verkey,)
routing_keys = ()
sender_key = local_did.verkey
Expand Down Expand Up @@ -177,7 +177,7 @@ async def test_forward(self):
router_did = await self.wallet.create_local_did(
method=SOV, key_type=ED25519, seed=self.test_routing_seed
)
serializer = PackWireFormat()
serializer = V1PackWireFormat()
recipient_keys = (local_did.verkey,)
routing_keys = (router_did.verkey,)
sender_key = local_did.verkey
Expand Down Expand Up @@ -207,15 +207,15 @@ async def test_get_recipient_keys(self):
).decode()
}

serializer = PackWireFormat()
serializer = V1PackWireFormat()
actual_recip_keys = serializer.get_recipient_keys(json.dumps(enc_message))

self.assertEqual(recip_keys, actual_recip_keys)

async def test_get_recipient_keys_fails(self):
enc_message = {"protected": {}}

serializer = PackWireFormat()
serializer = V1PackWireFormat()

with self.assertRaises(RecipientKeysError):
serializer.get_recipient_keys(json.dumps(enc_message))

0 comments on commit 3b0c966

Please sign in to comment.