Merge pull request hyperledger#2731 from ianco/fix/issue/2714

Relax validation of holder DID when submitting a credential request

aries_cloudagent/anoncreds/holder.py

@@ -128,7 +128,7 @@ async def create_credential_request(
         Args:
             credential_offer: The credential offer to create request for
             credential_definition: The credential definition to create an offer for
-            holder_did: the DID of the agent making the request
+            holder_did: the DID of the agent making the request (may not be a real DID)
 
         Returns:
             A tuple of the credential request and credential request metadata

aries_cloudagent/indy/models/cred_request.py

@@ -8,8 +8,7 @@
 from ...messaging.valid import (
     INDY_CRED_DEF_ID_EXAMPLE,
     INDY_CRED_DEF_ID_VALIDATE,
-    INDY_DID_EXAMPLE,
-    INDY_DID_VALIDATE,
+    UUID4_EXAMPLE,
     NUM_STR_WHOLE_EXAMPLE,
     NUM_STR_WHOLE_VALIDATE,
 )
@@ -52,8 +51,10 @@ class Meta:
 
     prover_did = fields.Str(
         required=True,
-        validate=INDY_DID_VALIDATE,
-        metadata={"description": "Prover DID", "example": INDY_DID_EXAMPLE},
+        metadata={
+            "description": "Prover DID/Random String/UUID",
+            "example": UUID4_EXAMPLE,
+        },
     )
     cred_def_id = fields.Str(
         required=True,

demo/features/0454-present-proof.feature

@@ -26,7 +26,7 @@ Feature: RFC 0454 Aries agent present proof
          | Faber  | --public-did                           | --wallet-type askar-anoncreds | driverslicense_v2 | Data_DL_MaxValues | DL_age_over_19_v2 |
 
 
-   @T001-RFC0454-DID-PEER
+   @T001-RFC0454-DID-PEER @GHA
    Scenario Outline: Present Proof where the prover does not propose a presentation of the proof and is acknowledged
       Given we have "2" agents
          | name  | role     | capabilities        | extra        |