fix anoncreds proof request #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Burdett <burdettadam@gmail.com>
dbluhm
reviewed
May 25, 2023
Comment on lines
+123
to
136
| rev_reg = ( | ||
| await anoncreds_registry.get_revocation_registry_definition( | ||
| self._profile, revocation_registry_id | ||
| ) | ||
| ).revocation_registry.serialize() | ||
| # add id to the serialized rev_reg | ||
| rev_reg["id"] = revocation_registry_id | ||
| revocation_registries[ | ||
| revocation_registry_id | ||
| ] = RevocationRegistry.from_definition( | ||
| ( | ||
| await anoncreds_registry.get_revocation_registry_definition( | ||
| self._profile, revocation_registry_id | ||
| ) | ||
| ).revocation_registry.serialize(), | ||
| rev_reg, | ||
| True, | ||
| ) | ||
| return schemas, cred_defs, revocation_registries |
There was a problem hiding this comment.
We should replace use of RevocationRegistry with RevRegDef; this causes a small cascade of changes needed up the stack from where this method is called but it shouldn't be too painful of a refactor. See 81ab818#diff-fd952db170fd7d5742268e460f9e739c3e9106a06f4e6e2556a634074841977aL447-R396
There was a problem hiding this comment.
We will address this in a separate set of changes
…defintion Signed-off-by: Char Howland <char@indicio.tech>
dbluhm
approved these changes
May 26, 2023
dbluhm
merged commit 08056f8
into
feature/anoncreds-revocation-again
4 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.