New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: update lwip dependency #123

Merged

sihrc merged 2 commits into master from development

Oct 16, 2016

Member

sihrc commented Oct 16, 2016

Reviewers:

@mention

What's the purpose of the PR?

Description of changes

Notes to reviewers

Keep in mind while reviewing code:

Is relevant code tested?
Are added functions/methods documented?
Separation of concerns (SOC)
Don't repeat yourself (DRY)
Limit the number of positional arguments
Is function/method length reasonable?
Can code be broken down into smaller components?
Where do added functions/methods belong?
Are variable names descriptive?
Are errors handled appropriately?
Can logic be simplified?
Does the code make sense in context? (expand the diff)

sihrc added 2 commits

October 16, 2016 16:02


          FIX: update lwip dependency

ab6b128


          UPDATE: version tick

ab18f44

sihrc merged commit 42dfce9 into master

sihrc mentioned this pull request

LWIP installation issues #67

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment