Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update submission filter #294

Merged
merged 14 commits into from
Mar 5, 2024
Merged

update submission filter #294

merged 14 commits into from
Mar 5, 2024

Conversation

nateshim-indico
Copy link
Contributor

Summary

@nateshim-indico nateshim-indico marked this pull request as ready for review March 4, 2024 17:48
pastap
pastap reviewed Mar 4, 2024
View reviewed changes
indico/queries/submission.py Outdated Show resolved Hide resolved
pastap
pastap reviewed Mar 4, 2024
View reviewed changes
indico/queries/submission.py Outdated Show resolved Hide resolved
pastap
pastap reviewed Mar 4, 2024
View reviewed changes
indico/queries/submission.py Outdated Show resolved Hide resolved
pastap
pastap reviewed Mar 4, 2024
View reviewed changes
indico/types/filetype.py Outdated Show resolved Hide resolved
pastap
pastap reviewed Mar 4, 2024
View reviewed changes
indico/types/submission.py Outdated Show resolved Hide resolved
@pastap
Copy link
Contributor

pastap commented Mar 4, 2024

final request - can you please add this CODEOWNERS file to this repo as part of your PR? it'll start automatically including folks in PRs against master https://github.com/IndicoDataSolutions/elnino/blob/development/CODEOWNERS

jacobmanderson
jacobmanderson previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jacobmanderson jacobmanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, not super necessary to change

examples/submission-filters.py Show resolved Hide resolved
indico/filters/__init__.py Outdated Show resolved Hide resolved
@nateshim-indico nateshim-indico merged commit 1547bd6 into master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastap pastap pastap left review comments

@goatrocks goatrocks goatrocks approved these changes

@jacobmanderson jacobmanderson jacobmanderson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nateshim-indico @pastap @goatrocks @jacobmanderson