adjust tests for statsExpressions changes; more args cleanup #405

IndrajeetPatil · 2020-03-31T22:22:56Z

No description provided.

lintr-bot · 2020-03-31T22:38:22Z

R/ggbarstats.R:51:1: style: functions should have cyclomatic complexity of less than 15, this has 17.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:191:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:273:1: style: functions should have cyclomatic complexity of less than 15, this has 54.

ggcoefstats <- function(x,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:88:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

tests/testthat/test-ggcoefstats.R:339:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(1*\",\"*28)==118.89, ~italic(p)<= 0.001, ~widehat(italic(eta)[p]^2)==0.81)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:411:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(3*\",\"*35)==7.388, ~italic(p)== 0.001, ~widehat(italic(omega)[p]^2)==0.308)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:412:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(1*\",\"*35)==2.034, ~italic(p)== 0.163, ~widehat(italic(omega)[p]^2)==0.023)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:413:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(3*\",\"*35)==4.012, ~italic(p)== 0.015, ~widehat(italic(omega)[p]^2)==0.174)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcorrmat.R:243:7: style: Commented code should be removed.

    # testthat::expect_equal(dim(pb$data[[3]]), c(1L, 10L))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

lintr-bot · 2020-03-31T22:39:07Z

R/ggbarstats.R:51:1: style: functions should have cyclomatic complexity of less than 15, this has 17.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:191:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:273:1: style: functions should have cyclomatic complexity of less than 15, this has 54.

ggcoefstats <- function(x,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:88:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

tests/testthat/test-ggcoefstats.R:339:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(1*\",\"*28)==118.89, ~italic(p)<= 0.001, ~widehat(italic(eta)[p]^2)==0.81)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:411:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(3*\",\"*35)==7.388, ~italic(p)== 0.001, ~widehat(italic(omega)[p]^2)==0.308)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:412:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(1*\",\"*35)==2.034, ~italic(p)== 0.163, ~widehat(italic(omega)[p]^2)==0.023)",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcoefstats.R:413:1: style: Lines should not be more than 100 characters.

        "list(~italic(F)(3*\",\"*35)==4.012, ~italic(p)== 0.015, ~widehat(italic(omega)[p]^2)==0.174)"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/testthat/test-ggcorrmat.R:243:7: style: Commented code should be removed.

    # testthat::expect_equal(dim(pb$data[[3]]), c(1L, 10L))
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

codecov · 2020-04-04T22:35:18Z

Codecov Report

Merging #405 into master will decrease coverage by 0.002%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##            master      #405       +/-   ##
=============================================
- Coverage   99.957%   99.955%   -0.002%     
=============================================
  Files           27        27               
  Lines         2332      2234       -98     
=============================================
- Hits          2331      2233       -98     
  Misses           1         1

Impacted Files	Coverage Δ
R/grouped_ggcorrmat.R	`100% <ø> (ø)`	⬆️
R/grouped_ggbetweenstats.R	`100% <ø> (ø)`	⬆️
R/grouped_ggpiestats.R	`100% <ø> (ø)`	⬆️
R/grouped_ggwithinstats.R	`100% <ø> (ø)`	⬆️
R/grouped_ggscatterstats.R	`100% <ø> (ø)`	⬆️
R/grouped_gghistostats.R	`100% <ø> (ø)`	⬆️
R/ggpiestats.R	`100% <ø> (ø)`	⬆️
R/grouped_ggdotplotstats.R	`100% <ø> (ø)`	⬆️
R/grouped_ggbarstats.R	`100% <ø> (ø)`	⬆️
R/helpers_grouped_functions.R	`100% <100%> (ø)`	⬆️
... and 9 more

lintr-bot · 2020-04-04T22:49:39Z

R/ggbarstats.R:51:1: style: functions should have cyclomatic complexity of less than 15, this has 17.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:191:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:273:1: style: functions should have cyclomatic complexity of less than 15, this has 54.

ggcoefstats <- function(x,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:88:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

lintr-bot · 2020-04-04T22:51:51Z

R/ggbarstats.R:51:1: style: functions should have cyclomatic complexity of less than 15, this has 17.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:191:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:273:1: style: functions should have cyclomatic complexity of less than 15, this has 54.

ggcoefstats <- function(x,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:88:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

lintr-bot · 2020-04-07T08:35:51Z

R/ggbarstats.R:51:1: style: functions should have cyclomatic complexity of less than 15, this has 17.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:191:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:273:1: style: functions should have cyclomatic complexity of less than 15, this has 54.

ggcoefstats <- function(x,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:88:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

lintr-bot · 2020-04-07T08:36:07Z

R/ggbarstats.R:51:1: style: functions should have cyclomatic complexity of less than 15, this has 17.

ggbarstats <- function(data,
^

R/ggbetweenstats.R:191:1: style: functions should have cyclomatic complexity of less than 15, this has 26.

ggbetweenstats <- function(data,
^

R/ggcoefstats.R:273:1: style: functions should have cyclomatic complexity of less than 15, this has 54.

ggcoefstats <- function(x,
^

R/gghistostats.R:70:1: style: functions should have cyclomatic complexity of less than 15, this has 19.

gghistostats <- function(data,
^

R/ggpiestats.R:88:1: style: functions should have cyclomatic complexity of less than 15, this has 20.

ggpiestats <- function(data,
^

R/ggscatterstats.R:94:1: style: functions should have cyclomatic complexity of less than 15, this has 29.

ggscatterstats <- function(data,
^

R/ggwithinstats.R:68:1: style: functions should have cyclomatic complexity of less than 15, this has 24.

ggwithinstats <- function(data,
^

adjust tests for statsExpressions changes; more args cleanup

28533cd

more catching up with changes to dependencies

de14b3f

update website; fix ggcoefstats caption regression

93720d1

IndrajeetPatil added 4 commits April 12, 2020 09:52

catch up to all import cran updates; website

096adc6

minor cleanup

9edf1bb

prepare for cran 0.4.0 submission

29ca517

minor theme changes

82ad4ff

IndrajeetPatil merged commit 0702036 into master Apr 15, 2020

IndrajeetPatil deleted the devel_4.0.0 branch April 15, 2020 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adjust tests for statsExpressions changes; more args cleanup #405

adjust tests for statsExpressions changes; more args cleanup #405

IndrajeetPatil commented Mar 31, 2020

lintr-bot commented Mar 31, 2020

lintr-bot commented Mar 31, 2020

codecov bot commented Apr 4, 2020 •

edited

lintr-bot commented Apr 4, 2020

lintr-bot commented Apr 4, 2020

lintr-bot commented Apr 7, 2020

lintr-bot commented Apr 7, 2020

adjust tests for statsExpressions changes; more args cleanup #405

adjust tests for statsExpressions changes; more args cleanup #405

Conversation

IndrajeetPatil commented Mar 31, 2020

lintr-bot commented Mar 31, 2020

lintr-bot commented Mar 31, 2020

codecov bot commented Apr 4, 2020 • edited

Codecov Report

lintr-bot commented Apr 4, 2020

lintr-bot commented Apr 4, 2020

lintr-bot commented Apr 7, 2020

lintr-bot commented Apr 7, 2020

codecov bot commented Apr 4, 2020 •

edited