Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Picker #113

Open
amandahmeng opened this issue Feb 13, 2024 · 2 comments · Fixed by #122
Open

Date Picker #113

amandahmeng opened this issue Feb 13, 2024 · 2 comments · Fixed by #122
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@amandahmeng
Copy link
Collaborator

Currently the date picker is clunky and requires several extra clicks
To update the date range you have to click the start date, select the start date in the calendar, then click the end date, and select the end date in the calendar. We would like to update this to just click the start and end date in the calendar.

@amandahmeng amandahmeng added enhancement New feature or request good first issue Good for newcomers labels Feb 13, 2024
@asylbek09
Copy link
Contributor

We can update to just click the start and end date in the calendar but then we loose the granular input control for the time (hours, minutes and am/pm) inputs. If we are ok with that approach and default times, then we can change to simple date range picker. According to And Design's DatePicker we can choose between simple and advanced pickers. In advanced picker end date is also preselected but only after we click OK button.

@amandahmeng
Copy link
Collaborator Author

From @asylbek09 The [RangePicker](https://ant.design/components/date-picker#components-date-picker-demo-preset-ranges) component on the dashboard has been recently updated to allow for date selection without including times and without the need for clicking the "OK" button. However, there is an issue with implementing the same functionality on the Entity page.

The Entity component involves complex rendering of graphs, timelines, and other elements, which has resulted in a significant amount of code (approximately 3500 lines) being dedicated to its implementation. Therefore, implementing the RangePicker without times on the Entity page would require substantial changes to accommodate this new functionality.

While the change itself may seem straightforward, the sheer size and complexity of the Entity component mean that it would necessitate additional modifications throughout the codebase. I have already discussed this matter with Shane and provided an explanation of the situation.

If necessary, all three of us can schedule a meeting to further discuss the best approach moving forward. Please let me know your availability for a discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Reviewed and Deployed to Dev
Development

Successfully merging a pull request may close this issue.

3 participants