Support for nested files itm veh #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st this to see the actual issues - generally it's been issues with files needing to be opened and resaved to grab the latest "good" format to be parsed correctly, or it's stuff like nested file items that our system doesn't know how to handle. Either way, this mainly helps us get to more helpful errors.
…"nested" files hidden inside of them. There was already some support for this feature, but needed a little extra shove to get the nested files checked in as assets. This comes with a mandatory "out of memory" fix, or some of the files containing nested files will parse badly and run into an infinite loop issue until memory becomes an issue. I've tested to make sure this works in several already working zones, and I've tested and verified it worked on 3 out of 4 of the outofmemory(nested itm & veh zones: chaos4, CRPL, duel). Hauntedchaos has nested files that loads into the server without a hitch, but still has issues with launching locally (silent fail). If this PR gets out anytime soon, someone (if I don't remember to do it) will need to verify the mentioned zones work in Zone-Assets\Incompatible Zone Archives\OutOfMemory\ and then we can move those to the completed folder afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where some zones have .veh or .itm game files that have "nested" files hidden inside of them. There was already some support for this feature, but needed a little extra shove to get the nested files checked in as assets. This comes with a mandatory "out of memory" fix, or some of the files containing nested files will parse badly and run into an infinite loop issue until memory becomes an issue. I've tested to make sure this works in several already working zones, and I've tested and verified it worked on 3 out of 4 of the outofmemory(nested itm & veh zones: chaos4, CRPL, duel). Hauntedchaos has nested files that loads into the server without a hitch, but still has issues with launching locally (silent fail). If this PR gets out anytime soon, someone (if I don't remember to do it) will need to verify the mentioned zones work in Zone-Assets\Incompatible Zone Archives\OutOfMemory\ and then we can move those to the completed folder afterwards.