Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional comments from Seb #78

Closed
3 tasks done
eahowerton opened this issue May 15, 2024 · 1 comment
Closed
3 tasks done

Additional comments from Seb #78

eahowerton opened this issue May 15, 2024 · 1 comment

Comments

@eahowerton
Copy link
Contributor

eahowerton commented May 15, 2024

  • Some of the plots produce warnings (from cowplot::get_legend). Would it be worth trying to get rid of these?

  • In the FluSight examples you exclude the baseline model. Is there a particular rationale for this? I thought it was good practice to include this for regularisation purposes.

  • You're saying that "we evaluate the performance of these ensembles using scoring metrics that measure..." but then load the scores from a file and don't actually show how you're doing the evaluation. I know you're trying to not show too much detail but perhaps it would be good to have code for the evaluation somewhere for interested readers to check/see?

@lshandross
Copy link
Collaborator

The second paragraph of Section 5 has been updated in Commit 364aa4e to more directly specify that any code not shown in the manuscript can be found elsewhere in the linked repository. To me, this feels sufficient to address concerns (3)

lshandross added a commit that referenced this issue May 31, 2024
Fixes legends for figures 1 and 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants