Significantly improved panning performance #445
Conversation
…ornerRadius at all by not applying a mask to the IIViewDeckView. Applying a mask to IIViewDeckView is a really bad idea in any case because it significantly hurts drawing performance!
|
This seems to disable the centre controller shadow altogether if a corner radius is not set. Don't think this is what you intended... It certainly improves performance, though; because there's no shadow! |
|
are there any plans to update this with UIKit Dynamics? like what this guy built https://github.com/erichoracek/MSDynamicsDrawerViewController ? |
|
@Audentia I am currently working on v3.0.0 which basically is a reimplementation of the API. I haven't thought about using UIKit Dynamics but I am happy to discuss the pros and cons about this. Feel free to open a feature request! |
|
@michaelochs hey awesome! Yeah I've only dabbled with UIKit Dynamics so I'm not sure all the pros cons myself, but my understanding is its Apple's preferred way for UI animations now. I saw that other guys project and it looks promising, but he hasn't updated it in a while so was hesitant to use it in our production app. These are all purely selfish motivations, we are using viewdeck in our app and im just seeing how to make it the best it can be :) If i get time to dive in and find specific benefits of Dynamics I will happily open a feature request, and if really dive in, I'll submit a pull request :) |
|
Closing this PR for now. |
… when not using centerViewCornerRadius at all by not applying a mask to the IIViewDeckView.
Applying a mask to IIViewDeckView is a really bad idea in any case because it significantly hurts drawing performance! For now I just fixed it for the case where no corner radius was set at all.