Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Pokedex Layout & Drop Downs #6

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

✨ Pokedex Layout & Drop Downs #6

wants to merge 7 commits into from

Conversation

IsabellaS09
Copy link
Contributor

@IsabellaS09 IsabellaS09 commented Jan 24, 2024 •
edited by keithrfung
Loading

Move pokemon selection into a separate component with basic animation

Fixes #2
Fixes #4

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 24, 2024 •
edited
Loading

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ COPYPASTE jscpd yes 2 1.68s
❌ CSS stylelint 2 1 1 1.69s
✅ JSON eslint-plugin-jsonc 2 0 0 1.9s
✅ JSON jsonlint 2 0 0.36s
✅ JSON npm-package-json-lint yes no 0.84s
✅ JSON prettier 2 0 0 1.18s
✅ JSON v8r 2 0 8.71s
✅ REPOSITORY checkov yes no 13.8s
✅ REPOSITORY gitleaks yes no 0.27s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 12.98s
✅ REPOSITORY secretlint yes no 1.17s
✅ REPOSITORY trivy yes no 8.13s
✅ REPOSITORY trivy-sbom yes no 8.08s
✅ REPOSITORY trufflehog yes no 45.06s
✅ TSX eslint 3 0 0 4.99s
✅ TYPESCRIPT eslint 2 0 0 2.99s
✅ TYPESCRIPT prettier 2 2 0 1.21s
✅ TYPESCRIPT ts-standard 2 2 0 7.88s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

keithrfung
keithrfung reviewed Jan 29, 2024
View reviewed changes
app/pokedex.css
border: 5px solid #fff;
float: left;

box-shadow: 0 0 10px #490000;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is borrowing from something I wrote but we should at least isolate out the colors.

Long term I think these should be heavily componentized. Even if just for animations.

@IsabellaS09 IsabellaS09 force-pushed the task/retrieve-pokemon-data branch 2 times, most recently from fac8fa1 to a751496 Compare January 30, 2024 14:26
@IsabellaS09 IsabellaS09 force-pushed the task/retrieve-pokemon-data branch 2 times, most recently from da97ee2 to aef78ad Compare January 31, 2024 14:39
@keithrfung keithrfung force-pushed the task/retrieve-pokemon-data branch 2 times, most recently from 621558e to 83171bc Compare February 1, 2024 19:42
Base automatically changed from task/retrieve-pokemon-data to main February 2, 2024 15:06
@keithrfung keithrfung changed the title Add tailwind and framer motion ✨ Pokedex Layout Feb 2, 2024
@keithrfung keithrfung changed the title ✨ Pokedex Layout ✨ Pokedex Layout & Drop Downs Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithrfung keithrfung keithrfung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Pokedex DropDowns / Inputs Design Pokedex Layout
2 participants
@IsabellaS09 @keithrfung