Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Tab to be set from outside, Keyboard navigation #741

Merged
merged 56 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
bc639ce
tabs bug fixed, and publuc method to set active tab from outside
Nov 20, 2023
fecad2c
added setActiveTab method to angular example
Nov 20, 2023
d487478
updated the documentation regarding the Tabs method setActiveTab()
Nov 27, 2023
4ebf4ec
tab header focus and keyboard navigation added
Nov 29, 2023
04eebde
tab logic cleaned up
Nov 30, 2023
ebe2fac
lock-file update
Dec 4, 2023
00f226c
updated gh-actions to fix angular preview deployment
Dec 4, 2023
aaf4a8d
Merge branch 'master' into 738-tabs-set-active-tab-from-the-outside
Dec 4, 2023
2f7583b
fix for angular example app, status component configuration
Dec 4, 2023
877f825
Merge branch 'master' into 738-tabs-set-active-tab-from-the-outside
Dec 4, 2023
3f47005
lock-file synced
Dec 4, 2023
236a034
lock-file updated
Dec 4, 2023
4dc7935
updated tabs story with correct eventname
Dec 4, 2023
8f7cc0f
tabs example apps update
Dec 4, 2023
87c5baf
removed console statement; fixed img path in Card.vue
Dec 4, 2023
a4a6248
removed comment
Dec 4, 2023
95911f0
example apps updated to emit less console statements
Dec 4, 2023
ab6e124
lock-files updated
Dec 5, 2023
0b9b52c
Merge branch 'master' into 738-tabs-set-active-tab-from-the-outside
Dec 6, 2023
785530c
tab focus keyboard navigation aligned with latest design requirements
Dec 7, 2023
de35d43
removed console log
Dec 7, 2023
88acf1c
cleaned up tab story
Dec 8, 2023
20889d5
vue example updated
Dec 8, 2023
ba0e635
tabs component changed in react example
Dec 8, 2023
ca7f547
further clean up of tab component
Dec 11, 2023
76206cb
Merge branch 'master' into 738-tabs-set-active-tab-from-the-outside
Dec 11, 2023
d69e43e
working directory cleaned
Dec 11, 2023
034e2f5
angular example fixed
Dec 11, 2023
70e8192
react example fix
Dec 11, 2023
522561b
documentation updated for tabs
Dec 11, 2023
a8a7cdd
removed unused code
Dec 11, 2023
871256d
removed redundant setting of the activetabindex prop
Dec 12, 2023
9c663e4
testing new config for creating wrapper components
Dec 12, 2023
c9800ea
testing new config for creating wrapper components
Dec 12, 2023
01ba296
wd cleaned
Dec 12, 2023
bebb487
stencil config fixed
Dec 12, 2023
83c9870
potential bug fix to props not being set-able
Dec 13, 2023
c36b68e
potential bug fix to props not being set-able
Dec 13, 2023
acdb1d6
Merge branch '738-tabs-set-active-tab-from-the-outside' of https://gi…
Dec 13, 2023
756d226
tabs - added method to update styles when prop changes
Dec 13, 2023
1f8f64e
fix to local testing in example apps
Dec 15, 2023
add3500
reverted back to using name from package.json when running local test…
Dec 15, 2023
80bda42
reflect updates in stencil library in example apps while testing
Dec 15, 2023
7e307bc
docs flag when watching stencil build not needed
Dec 15, 2023
ab6480a
tabs fixed, example app testing now working after change in build and…
Dec 17, 2023
68f547e
updated script to work on windows and unix
Dec 18, 2023
4a807f2
Merge branch 'master' into 738-tabs-set-active-tab-from-the-outside
Dec 18, 2023
5558058
lock file cleaned
Dec 18, 2023
8be469f
package.json updates
Dec 18, 2023
7f19f1b
remove the node modules before building the wrappers
Dec 18, 2023
839301f
changed to npm i in storybook deplyment action
Dec 18, 2023
6db4da3
wd cleaned
Dec 18, 2023
e97114a
updated package.json scripts to test vue + react example apps locally
Dec 19, 2023
457db2f
Merge branch 'master' into 738-tabs-set-active-tab-from-the-outside
Dec 19, 2023
1c87452
rm folder stencil-compoennts as it should not be tracked
Dec 19, 2023
c931483
install latest canary release of stencil library in vue and react wra…
Dec 19, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
echo "VERSION: $VERSION"
echo "Installing Stencil library for Vue and React: $VERSION"
echo "Installing Stencil library for Angular, Vue and React: $CANARY_VERSION"
cd packages/components-angular/projects/component-library
npm install @infineon/infineon-design-system-stencil@"$CANARY_VERSION"
cd ../../../../
npm install @infineon/infineon-design-system-stencil@latest -w @infineon/infineon-design-system-vue
npm install @infineon/infineon-design-system-stencil@latest -w @infineon/infineon-design-system-react

Expand All @@ -59,8 +61,9 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
lerna version $VERSION --no-git-tag-version --y
lerna version $CANARY_VERSION --no-git-tag-version --y
npm run build:components-angular
npm run build:components-react
npm run build:components-vue
cd packages/components-angular/dist/@infineon/infineon-design-system-angular
npm publish
Expand Down
15 changes: 8 additions & 7 deletions examples/stencil-components/vanilla-cdn/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -281,21 +281,22 @@ <h2>Switch</h2>
<br />
<br />

<h2>Status</h2>
<ifx-status label="Status with border" color="orange" border="true" />
<ifx-status label="Status without border" color="orange" border="false" />
<br />
<br />


<h2>Tabs</h2>
<ifx-tabs orientation="horizontal">
<ifx-tabs :active-tab-index="0" orientation="horizontal">
<ifx-tab header="tab header 1">tab 1 content</ifx-tab>
<ifx-tab header="tab header 2">tab 2 content</ifx-tab>
<ifx-tab header="tab header 3">tab 3 content</ifx-tab>
</ifx-tabs>
<br />
<br />
<h2>Status</h2>
<ifx-status label="Status with border" color="orange" border="true" />
<ifx-status label="Status without border" color="orange" border="false" />
<br />
<br />




<h2>Tag</h2>
Expand Down
Loading
Loading