Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved notification UI #108

Merged
merged 8 commits into from
Oct 27, 2020
Merged

Improved notification UI #108

merged 8 commits into from
Oct 27, 2020

Conversation

JF002
Copy link
Collaborator

@JF002 JF002 commented Oct 20, 2020

The goal of this PR is to provide a better notification UI. The current UI consists in a modal dialog box that can only display the first 18 characters of the last notification received.

This new UI provide a new app that can display more content (full screen) and the last 5 notification received.

When a new notification is received

  • while the Clock app is shown, the notification is displayed for 5s.
  • while the display is OFF, the display is first switched on and the notification is displayed for 5s.
  • while another app is shown, nothing is displayed (don't want to disturb the user). When the user goes back to the Clock app, an icon is displayed on the top left to notify him that a notification is available. He can then see all the notifications using the new Notification app.

Here is a demo of the current implementation : https://video.codingfield.com/videos/watch/5395d13a-a287-4689-9ec6-750f291e23b8

My goal here is to provide a simple notification UI that is usable (the previous one was just a proof of concept, but barely usable). Other ideas and improvements have been discussed on the Pinetime chat room, but I think we can implement it in the future (maybe someone with more UI experience will be able to do something a bit more shiny ?).

What do you think of it? Should I changed/improve something?

TODO:

@JF002 JF002 added the enhancement Enhancement to an existing app/feature label Oct 20, 2020
@JF002
Copy link
Collaborator Author

JF002 commented Oct 22, 2020

Here is a new video of the Notification app : https://video.codingfield.com/videos/watch/fb8c766c-7cb6-4ad5-af62-8f9a3dc85233.

…a grey border on the bottom that is displayed when there are other notifications to available.
@JF002 JF002 marked this pull request as ready for review October 27, 2020 20:53
@JF002 JF002 merged commit cb9e881 into develop Oct 27, 2020
@Avamander Avamander deleted the notification-ui branch September 27, 2022 21:28
tgc-dk pushed a commit to tgc-dk/InfiniTime that referenced this pull request Nov 28, 2023
main: add missing argument in lcd driver constructor call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing app/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant