Fix EOL related build issues on Windows #2077
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix for #1275 that does no longer require manual intervention.
On Windows, git has
core.autocrlf=true
set at system level, hence any Windows user who has not changed their global git config will checkout all text files with CRLF line endings. For some files this seems to cause build issues.With this change, I can build using docker on Windows 11 as follows:
Without the change, the build fails with an error that matches the one described in #1275:
Note: when changing between branches with varying
.gitattributes
withcheckout
instead of directly cloning with--branch
, resetting the line endings is more complicated: