Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Array operators #143

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

olliemath
Copy link

Added has, hasAny etc. for arrays - with some docs and tests

@ishirav
Copy link
Contributor

ishirav commented May 1, 2020

Hi Oliver,

Thank you very much for your high-quality pull request. I see that you've included tests and documentation, which is great.

I'm currently working on finishing up v2.0 of the ORM, which will include support for these array functions (and many more), using a much richer and natural syntax for using database function. For example you could do something like this:

# Find people with more than two cars
Person.objects_in(db).filter(F.length(Person.cars) > 2)

In view of this, I prefer not to add new functions in the old format (although v2.0 will still support them).

Please don't see this as any kind of disapproval of your work. I hope this won't discourage you from contributing additional pull requests in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants