Miscellaneous cleanup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be no functionality changes, but I didn't test it :-)
I didn't worry very much about correctness -- I figure if we ever get the sender clock sent over the network, that's the time to think about revisiting this and trying to do a better job, if ever.
Like we figured in person, we can probably get some easy efficiency wins by changing the
setinterface to do everything at once and by doing less defensive copies, but it's probably not a super big deal with order of 10 people in a room. (FYI, you could also optimize the lerping part -- callinglerpVectorseach time does duplicate work if you're going to repeatedly call it with the same origin and target and differentalpha.) Once we deploy this we should check the profiler to see whether it warrants improving.