Update unfound secret return to os.environ

Infisical · Aug 21, 2023 · a72e48c · a72e48c
1 parent 89293f2
commit a72e48c
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes will be documented in this file.
 
+## [1.4.1] - 2023-07-13
+
+This version updates returning unfound secrets to whatever is present on `os.environ` as opposed to returning `None`.
+
 ## [1.4.0] - 2023-07-13
 
 This version adds support for folders or path-based secret storage for all secret CRUD operations.

diff --git a/infisical/__version__.py b/infisical/__version__.py
@@ -1 +1 @@
-__version__ = "1.4.0"
+__version__ = "1.4.1"
diff --git a/infisical/services/secret_service.py b/infisical/services/secret_service.py
@@ -1,3 +1,4 @@
+import os
 from datetime import datetime
 from typing import List
 
@@ -50,7 +51,7 @@ def populate_client_config(
     def get_fallback_secret(secret_name: str) -> SecretBundle:
         return SecretBundle(
             secret_name=secret_name,
-            secret_value=None,
+            secret_value=os.environ[secret_name],
             is_fallback=True,
             last_fetched_at=datetime.now(),
         )

diff --git a/tests/test_client/test_infisical_client.py b/tests/test_client/test_infisical_client.py
@@ -14,6 +14,8 @@ def client():
     infisical_client.create_secret("KEY_ONE", "KEY_ONE_VAL_PERSONAL", type="personal")
     infisical_client.create_secret("KEY_TWO", "KEY_TWO_VAL")
 
+    # infisical_client.create_secret("TESTOO", "sssss", path="/foo", environment="dev")
+
     yield infisical_client
 
     infisical_client.delete_secret("KEY_ONE")