Fix: JSON error check

Infisical · Apr 17, 2024 · cb6cbaf · cb6cbaf
1 parent bcb3eaa
commit cb6cbaf
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/cli/test/export_test.go b/cli/test/export_test.go
@@ -31,7 +31,10 @@ func ExportSecrets(t *testing.T, authToken string, projectId string, envSlug str
 
 	var secrets []models.SingleEnvironmentVariable
 
-	json.Unmarshal(commandOutput.Bytes(), &secrets)
+	err := json.Unmarshal(commandOutput.Bytes(), &secrets)
+	if err != nil {
+		t.Errorf("Error: %v", err)
+	}
 
 	expectedLength := len(ALL_SECRETS) - 1 // -1 because the default path is "/", and the secret in /folder will not be found.
 
@@ -68,7 +71,10 @@ func ExportSecretsWithoutImports(t *testing.T, authToken string, projectId strin
 
 	var secrets []models.SingleEnvironmentVariable
 
-	json.Unmarshal(commandOutput.Bytes(), &secrets)
+	err := json.Unmarshal(commandOutput.Bytes(), &secrets)
+	if err != nil {
+		t.Errorf("Error: %v", err)
+	}
 
 	assert.Len(t, secrets, len(DEV_SECRETS))
 

diff --git a/cli/test/secrets_test.go b/cli/test/secrets_test.go
@@ -33,7 +33,10 @@ func ListSecretsWithImportsAndRecursive(t *testing.T, authToken string, projectI
 
 	var secrets []models.SingleEnvironmentVariable
 
-	json.Unmarshal(commandOutput.Bytes(), &secrets)
+	err := json.Unmarshal(commandOutput.Bytes(), &secrets)
+	if err != nil {
+		t.Errorf("Error: %v", err)
+	}
 
 	if len(secrets) == 0 {
 		t.Errorf("No secrets found")
@@ -79,7 +82,10 @@ func GetSecretsByNames(t *testing.T, authToken string, projectId string, envSlug
 
 	var secrets []models.SingleEnvironmentVariable
 
-	json.Unmarshal(commandOutput.Bytes(), &secrets)
+	err := json.Unmarshal(commandOutput.Bytes(), &secrets)
+	if err != nil {
+		t.Errorf("Error: %v", err)
+	}
 
 	assert.Len(t, secrets, len(ALL_SECRETS))