Add support for LDAP authentication + Aliases #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangtony98
changed the title
akhilmhdh
requested changes
Mar 7, 2024
| const doc = await orgBotDAL.findOne({ orgId }, tx); | ||
| if (doc) return doc; | ||
|
|
||
| const { privateKey, publicKey } = generateAsymmetricKeyPair(); |
There was a problem hiding this comment.
Can we move the encryption to outside the transaction. Because the more time a transaction takes the more table lock in time.
There was a problem hiding this comment.
I was thinking this at first but I think the encryption logic is actually not expensive; I've taken this from somewhere else in the codebase where this pattern was implemented.
frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/LDAPModal.tsx
Show resolved
Hide resolved
frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/LDAPModal.tsx
Outdated
Show resolved
Hide resolved
…er compose profile, update ldap form logic to use zod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR adds support for the LDAP authentication method.
With this update, an admin can configure an organization in Infisical to connect to an LDAP server (e.g. Active Directory, JumpCloud LDAP, etc.). After doing so, users that log in via the LDAP method are created to exist within the corresponding organization in Infisical only and hence can only access that organization.
This includes:
usernamefield for users hereon instead ofemail.Type ✨