Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic secret AWS IAM #1731

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Dynamic secret AWS IAM #1731

merged 5 commits into from
Apr 30, 2024

Conversation

akhilmhdh
Copy link
Member

Description 📣

  1. Implemented AWS IAM Dynamic secret

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@akhilmhdh akhilmhdh added the 🚀 feature request New feature or request label Apr 24, 2024
@akhilmhdh akhilmhdh requested a review from maidul98 April 24, 2024 13:19
@akhilmhdh akhilmhdh self-assigned this Apr 24, 2024
maidul98
maidul98 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, i also tested creation and deletion and renew

backend/src/ee/services/dynamic-secret/providers/aws-iam.ts Show resolved Hide resolved
docs/documentation/platform/dynamic-secrets/aws-iam.mdx Show resolved Hide resolved
@maidul98 maidul98 merged commit c41518c into Infisical:main Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees

@akhilmhdh akhilmhdh

Labels
🚀 feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akhilmhdh @maidul98