7.13 compatibility fix #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brgruber92
requested changes
Apr 16, 2024
|
QA review complete. Expected bug fix approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses issues with the 7.13 API which broke this tool. This change fixes it by using the user.FirstName & user.LastName properties to derive each user's name rather than the user.FullName property, which is now null in all cases.
I also had to update the configuration of CopyWebpackPlugin to match it's new configuration options schema & update the webpack npm script to remove out of date cli arguments (
-pand--https false), since webpack now rejects cli calls that contain unexpected arguments.In order to test, you will have to swap out the commented out code source locations in Manifest.xml at lines 41/42, and lines 101 - 104. I did not commit changing that to dev locations, since we do not want to deploy it with dev locations. Other than that, just building & starting it should work as normal.