Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config option for changing index lock file path #37

Merged
merged 4 commits into from Aug 11, 2017

Conversation

lcharkiewicz
Copy link
Contributor

Added possibility to change value of FILE_LOCK constant in config (at the same level as search_index option).

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage decreased (-0.2%) to 92.164% when pulling be981f5 on lcharkiewicz:lock_file_config into 3f42d7c on InfluxGraph:master.

@pkittenis
Copy link
Collaborator

Hi there, thanks for the interest and the PR.

This was missing, thanks for the addition. Could you put an example entry in the example config? Looks good for merging otherwise.

@lcharkiewicz
Copy link
Contributor Author

Hey,
I've added the example configuration also for search_index. Wanted to make it clear enough. :)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.515% when pulling 375c0d4 on lcharkiewicz:lock_file_config into 3f42d7c on InfluxGraph:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.515% when pulling 375c0d4 on lcharkiewicz:lock_file_config into 3f42d7c on InfluxGraph:master.

@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage increased (+0.1%) to 92.515% when pulling 375c0d4 on lcharkiewicz:lock_file_config into 3f42d7c on InfluxGraph:master.

@pkittenis
Copy link
Collaborator

Oh, just realised that. Since it's an influxgraph configuration setting, it should be under influxgraph section in config, if you don't mind making that change.

@lcharkiewicz
Copy link
Contributor Author

lcharkiewicz commented Aug 11, 2017

Sure, moved it to the influxdb section (I assumed you meant that one). If should be in a new, influxgraph section I'll move it.

@pkittenis
Copy link
Collaborator

Thanks! The code is currently failing the flake8 check - https://travis-ci.org/InfluxGraph/influxgraph/jobs/263538155

@coveralls
Copy link

coveralls commented Aug 11, 2017

Coverage Status

Coverage decreased (-0.2%) to 92.164% when pulling 0e1e923 on lcharkiewicz:lock_file_config into 3f42d7c on InfluxGraph:master.

@pkittenis pkittenis merged commit bad64e4 into InfluxGraph:master Aug 11, 2017
@pkittenis
Copy link
Collaborator

Looks great, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants