Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertical toolbar #32

Closed
mighelch opened this issue Mar 6, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@mighelch
Copy link

commented Mar 6, 2015

Can you adapt this button for vertical-toolbar addon?
https://addons.mozilla.org/en-US/firefox/addon/vertical-toolbar/

As you can see when folder is opened, it covers the items below. Can you move it at the edge of vertical toolbar?

Infocatcher added a commit that referenced this issue Mar 10, 2015

Add support for Vertical Toolbar extension
Note: should be detected any vertical toolbar, but detection of right-side position is extension-specific
(#32)
@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2015

I've added some corrections.
Also should be detected right-side vertical toolbar, but this detection is extension-specific (and will work only with Vertical Toolbar extension).

@mighelch

This comment has been minimized.

Copy link
Author

commented Mar 11, 2015

Thanks works fine.

@mighelch

This comment has been minimized.

Copy link
Author

commented Mar 15, 2015

Is it possible to disable "open on hover"? On vertical toolbar, when I click folder and go down in a rush to open a link at the bottom, I often hit the folder below.

@Infocatcher

This comment has been minimized.

Copy link
Owner

commented Mar 15, 2015

Is it possible to disable "open on hover"?

Currently only directly in code... For "Bookmarks Folder" button you can comment all that code:

this.onmouseover = function(e) {
    if(e.target != this)
        return;
    Array.some(
        this.parentNode.getElementsByTagName("*"),
        function(node) {
            if(
                node != this
                && node.namespaceURI == xulns
                && node.boxObject
                // See https://github.com/Infocatcher/Custom_Buttons/issues/28
                //&& node.boxObject instanceof Components.interfaces.nsIMenuBoxObject
                && "open" in node
                && node.open
                && node.getElementsByTagName("menupopup").length
            ) {
                node.open = false;
                this.open = true;
                return true;
            }
            return false;
        },
        this
    );
};

Like following:

/*
this.onmouseover = function(e) {
    ...
};
*/
@mighelch

This comment has been minimized.

Copy link
Author

commented Mar 16, 2015

Thank you.

Infocatcher added a commit that referenced this issue Oct 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.