-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced options for various download commands #10
Comments
Oh, too many things for options page...
|
Note: "useDownloadsHotkeyToTogglePanel" preference replaced with "overrideDownloadsHotkey" (first draft for #10)
Unfortunately we should do this before move focus to already opened library window (part 4 for #10)
Also we have "Downloads" button on about:home page... chrome://browser/content/browser.js messageManager.loadFrameScript("chrome://browser/content/content.js", true); chrome://browser/content/content.js onClick: function(aEvent) {
...
case "downloads":
sendAsyncMessage("AboutHome:Downloads"); resource:///components/nsBrowserGlue.js => resource:///modules/AboutHome.jsm MESSAGES: [
...
"AboutHome:Downloads",
...
],
init: function() {
let mm = Cc["@mozilla.org/globalmessagemanager;1"].getService(Ci.nsIMessageListenerManager);
for (let msg of this.MESSAGES) {
mm.addMessageListener(msg, this);
} Anyway, seems that we can't use this way to handle "AboutHome:Downloads" message (missing things like event.preventDefault()/stopPropagation()): |
…h real behavior + reorder options (#10)
(#10) See http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc #ifdef XP_GNOME <key id="key_search2" key="&searchFocusUnix.commandkey;" command="Tools:Search" modifiers="accel"/> <key id="key_openDownloads" key="&downloadsUnix.commandkey;" command="Tools:Downloads" modifiers="accel,shift"/> #else <key id="key_openDownloads" key="&downloads.commandkey;" command="Tools:Downloads" modifiers="accel"/> #endif
Note: this is not a "real" sidebar, but something that may be useful. Also unfortunately there is no easy way to show private downloads. (#10)
We already track
Tools:Downloads
command and downloads hotkey here: #2, also we should additionally handle#downloadsHistory
item ("Show All Downloads" button in download panel) for #6.So we can detect 1) downloads command, 2) downloads hotkey and 3) "Show All Downloads" from download panel.
And it's easy to do something good instead of default actions.
And we can override opening of "about:downloads" tab for private windows as well.
[added at 2014-01-13] Support for Downloads Window extension: #16
For example (see resource://app/components/DownloadsUI.js), open old window
or open downloads in tab
or open Library
The text was updated successfully, but these errors were encountered: