Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

middle click also removes download from history #39

Closed
GiftWolf opened this issue Aug 2, 2015 · 3 comments
Closed

middle click also removes download from history #39

GiftWolf opened this issue Aug 2, 2015 · 3 comments
Labels
bug compatibility

Comments

@GiftWolf
Copy link

GiftWolf commented Aug 2, 2015

I have the "Also remove from history" feature disabled. However when I middle click the download is also removed from history.
@Infocatcher
Copy link
Owner

Oops, something was changed in recent Firefox versions. I'll take a look.

With extensions.downloadPanelTweaker.debug = true in error/browser console:

[Download Panel Tweaker] 49:58:642 removeFromPanel(): dlController.dataItem.remove() not available!
[Download Panel Tweaker] 49:58:646 removeFromPanel() -> dlController.doCommand("cmd_delete")

Infocatcher added a commit that referenced this issue Aug 2, 2015
@Infocatcher
Correctly remove only from panel in Firefox 38+
5f79008 
(#39)
Infocatcher added a commit that referenced this issue Aug 2, 2015
@Infocatcher
Report error, if can't remove only from panel
a8c5915 
(#39)
@Infocatcher
Copy link
Owner

Now looks fixed for me.
Test version: download_panel_tweaker-0.2.5pre-fx.xpi (source code).

Infocatcher added a commit that referenced this issue Aug 9, 2015
@Infocatcher
Update changelog: #39 ("also remove from history" in Firefox 38+)
311bb1e
@Infocatcher
Copy link
Owner

https://addons.mozilla.org/firefox/addon/download-panel-tweaker/versions/0.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Infocatcher @GiftWolf