"New Private Tab" button can't be "placed" after last tab with installed Tab Mix Plus extension

[Infocatcher]

Toolbar's currentset in this case:

tabbrowser-tabs,tabmixScrollBox,new-tab-button,privateTab-toolbar-openNewPrivateTab,alltabs-button,tabs-closebutton

Should be selected Options – Display – Tab Bar – When tabs don't fit width: Multi-row

[Infocatcher]

Test version: private_tab-0.1.5.1pre-fx-sm.xpi (source source).

[onemen]

can't use the test version
Sun Sep 01 2013 23:21:07
Warning: WARN addons.xpi: Error loading bootstrap.js for privateTab@infocatcher: SyntaxError: unterminated string literal (resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/Hadar/AppData/Roaming/Mozilla/Firefox/Profiles/quqjpywe.Toolbar%20Tabs%20Strip/extensions/privateTab@infocatcher.xpi!/bootstrap.js:2802)
Source file: resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/Hadar/AppData/Roaming/Mozilla/Firefox/Profiles/quqjpywe.Toolbar%20Tabs%20Strip/extensions/privateTab@infocatcher.xpi!/bootstrap.js
Line: 2802

---

Sun Sep 01 2013 23:21:07
Warning: WARN addons.xpi: Add-on privateTab@infocatcher is missing bootstrap method startup
Source file: resource://gre/modules/XPIProvider.jsm
Line: 3991

[Infocatcher]

Oops, should be fixed now.

[onemen]

OK, this is better
there are still some minor problem, i will try to look at this more tomorrow

[onemen]

Tabmix have an option to show new tab button on the side even when the tabbar isn't over flow
in order to do it, i need you to change some of your css rules.
adding important to USER_SHEET styleSheet prevent Tabmix from override it (from visible to collapse)

this rules can replaced the rules you used:
#TabsToolbar[currentset]:not([currentset_="' + this.toolbarButtonId + '"])\n
#' + this.afterTabsButtonId + ',\n
#TabsToolbar[customizing="true"] #' + this.afterTabsButtonId + ',\n
#tabbrowser-tabs:not([overflow="true"])\n
~ #' + this.toolbarButtonId + ',\n
#TabsToolbar[currentset_="' + this.toolbarButtonId + '"]\n
> #tabbrowser-tabs:not([overflow="true"])\n
~ #new-tab-button {\n
visibility: collapse;\n
}\n
#TabsToolbar[currentset_="' + this.toolbarButtonId + '"]:not([customizing="true"])\n
> #tabbrowser-tabs:not([overflow="true"]) > .tabbrowser-arrowscrollbox >\n
#' + this.afterTabsButtonId + ',\n
#TabsToolbar[currentset_="new-tab-button"]:not([customizing="true"])\n
> #tabbrowser-tabs:not([overflow="true"]) > .tabbrowser-arrowscrollbox >\n
.tabs-newtab-button[command="cmd_newNavigatorTab"] {\n
visibility: visible !important;\n
}\n\

[Infocatcher]

Your style works wrong, if button is placed before tabs (and Tab Mix Plus isn't installed).

[onemen]

I see that with your code, in the case the button placed before tabs then it is visible only before tabs and never after the tabs.

try to add dynamically overflow attribute to privateTab-toolbar-openNewPrivateTab and add this rule to hide the button when not in overflow

#privateTab-toolbar-openNewPrivateTab:not([overflow="true"]) {
visibility: collapse;
}

regarding my proposed rule, as long as you don't use visibility: collapse !important; any rule is ok for me

[Infocatcher]

regarding my proposed rule, as long as you don't use visibility: collapse !important; any rule is ok for me

Only visibility: collapse !important;? I refactored my code and styles and removed !important from collapse, but still use visibility: visible !important; (see fc445b1 commit).

[onemen]

Yes.

i can override visibility: visible !important; with display: none but i can't override visibility: collapse !important; to show the "privateTab-toolbar-openNewPrivateTab" button when Tabmix preference is to show new tab button on the side all the time.

it will try to test how it work with fx445b1 commit

[Infocatcher]

I also added special check for [newtab_side]: d2bede7.

[onemen]

noticed that in the near future i'm going to change in Tabmix some attributes name to include "TabmixPkus-" prefix. so for now it is better if you left me to add the rules that relay on Tabmix attribute.

i'v tested your fc445b1 commint and without Tabmix when your button is before the tabbar it appear twice.
before the tabbar and after last tab.

currently with Tabmix, i need to fix my rules for the case that #new-tab-button is not on the tabbar. my rules currently hide your button as well

i hope to upload new test version later

[Infocatcher]

i'v tested your fc445b1 commint and without Tabmix when your button is before the tabbar it appear twice.
before the tabbar and after last tab.

Thanks, fixed: f3430ae

so for now it is better if you left me to add the rules that relay on Tabmix attribute.

OK, I'll remove :not([newtab_side]) after you update TMP.

[Infocatcher]

OK, I'll remove :not([newtab_side]) after you update TMP.

Done.