Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple resquest: Open in discarded tab #22

Closed
EstherMoellman opened this issue Mar 9, 2020 · 2 comments
Closed

Simple resquest: Open in discarded tab #22

EstherMoellman opened this issue Mar 9, 2020 · 2 comments
Labels
enhancement

Comments

@EstherMoellman
Copy link

EstherMoellman commented Mar 9, 2020 •
edited

Hi @Infocatcher ,

Firstly, thank you for your add-on.

Please, a simple request: Add an option to open links always in new discarded tab.
Thank you.
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Open in discarded tab: test draft
d16e225 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Open in discarded tab: add configuration UI
5218474 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Disable unsupported: load discarded only in background
063cb8a 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Use human-readable title for discarded tab
9053a2b 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Use human-readable title for discarded tab: also handle <a><img/></a>
fe2b77b 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Specify "discarded" only if needed, for better backward compatibility
ba07d32 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Show error message in case of unsupported browser.tabs.create() options
d19cbe9 
(#22)
Infocatcher added a commit that referenced this issue Mar 30, 2020
@Infocatcher
Update changelog:
800b5a3 
* open link in discarded (unloaded) tab (#22)
* correctly open tabs from non-focused window in MacOS (#23)
@Infocatcher
Copy link
Owner

Test version: right_links_we-0.5b10pre.xpi (source code).
(about:debugging -> This Firefox -> Load Temporary Add-on…)

@EstherMoellman
Copy link
Author

So I tried the "tested version"... very nice! It seems to work like a charm. Great job. Congrats.
I hope to see soon the updated version at AMO.
Thank you!

Infocatcher added a commit that referenced this issue Mar 13, 2021
@Infocatcher
Open in discarder tab: ignore text content & Co w/o non-spaces
66902a8 
(#22)
Infocatcher added a commit that referenced this issue Mar 14, 2021
@Infocatcher
Fix default options
f8c1684 
(changed by mistake in discarded tab implementation, see #22)
Infocatcher added a commit that referenced this issue Mar 14, 2021
@Infocatcher
Update changelog:
e82b0de 
* fixed default options (changed by mistake in #22)
* added separator between long left- and right-click options
Infocatcher added a commit that referenced this issue Mar 14, 2021
@Infocatcher
Fix trim() implementation, ignore undefined values
efa768f 
TypeError: String.prototype.trim called on incompatible undefined
(bug in 66902a8 commit, see #22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Infocatcher @EstherMoellman