Apply suggestion from code review

Infomaniak · May 21, 2024 · 4cd8825 · 4cd8825
1 parent 070fea0
commit 4cd8825
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt b/app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt
@@ -291,10 +291,7 @@ class ThreadListAdapter @Inject constructor(
             toggleMultiSelectedThread(thread)
         } else {
             previousThreadClickedPosition?.let { previousPosition ->
-                threadListAdapterCallback?.onPositionClickedChanged?.invoke(
-                    position,
-                    previousPosition
-                )
+                threadListAdapterCallback?.onPositionClickedChanged?.invoke(position, previousPosition)
             }
 
             previousThreadClickedPosition = position

diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt b/app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt
@@ -314,8 +314,7 @@ class ThreadListFragment : TwoPaneFragment(), SwipeRefreshLayout.OnRefreshListen
                 override var onPositionClickedChanged: ((position: Int, previousPosition: Int) -> Unit)? =
                     ::updateAutoAdvanceNaturalThread
             },
-            multiSelection =
-            object : MultiSelectionListener<Thread> {
+            multiSelection = object : MultiSelectionListener<Thread> {
                 override var isEnabled by mainViewModel::isMultiSelectOn
                 override val selectedItems by mainViewModel::selectedThreads
                 override val publishSelectedItems = mainViewModel::publishSelectedItems

diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt b/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt
@@ -147,7 +147,7 @@ class ThreadFragment : Fragment() {
         observeCurrentFolderName()
 
         observeThreadOpening()
-        observeAutoAdavance()
+        observeAutoAdvance()
     }
 
     override fun onConfigurationChanged(newConfig: Configuration) {
@@ -465,7 +465,7 @@ class ThreadFragment : Fragment() {
         }
     }
 
-    private fun observeAutoAdavance() {
+    private fun observeAutoAdvance() {
         mainViewModel.autoAdvanceThreadsUids.observe(viewLifecycleOwner) { listThreadsUids ->
             tryToAutoAdvance(listThreadsUids)
         }

diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml
@@ -394,8 +394,8 @@
     <string name="settingsAuthorizeTracking">Autorizar el seguimiento</string>
     <string name="settingsAutoAdvanceDescription">Seleccione qué mostrar cuando se archiva o elimina un mensaje</string>
     <string name="settingsAutoAdvanceFollowingThreadDescription">Mostrar la siguiente conversación al archivar o borrar</string>
-    <string name="settingsAutoAdvanceFollowingThreadTitle">Siguiendo la conversación</string>
-    <string name="settingsAutoAdvanceListOfThreadsDescription">Mostrar lista de conversaciones al archivar o borrar</string>
+    <string name="settingsAutoAdvanceFollowingThreadTitle">Conversación siguiente</string>
+    <string name="settingsAutoAdvanceListOfThreadsDescription">Mostrar la lista de conversaciones al archivar o borrar</string>
     <string name="settingsAutoAdvanceListOfThreadsTitle">Lista de conversaciones</string>
     <string name="settingsAutoAdvanceNaturalThreadDescription">Repite la última acción realizada</string>
     <string name="settingsAutoAdvanceNaturalThreadHint">Selecciona automáticamente la conversación siguiente o anterior, en función de tu última interacción.</string>