Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split this XXX characters long line (which is greater than 130 authorized). #1886

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

KevinBoulongne
Copy link
Contributor

Some lines were too long.

@KevinBoulongne KevinBoulongne added the optimization Improve the performance or efficiency of the code label Jun 4, 2024
@KevinBoulongne KevinBoulongne requested a review from a team June 4, 2024 05:08
@KevinBoulongne KevinBoulongne force-pushed the split-lines branch 2 times, most recently from f7d3506 to b849aad Compare June 4, 2024 05:30
@LunarX
Copy link
Contributor

LunarX commented Jun 4, 2024

Not sure this requiring this check is always productive actually

@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 4, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 4, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 7, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 7, 2024
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 429b8a6 into master Jun 11, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the split-lines branch June 11, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Improve the performance or efficiency of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants