Add more customisation to InformationBlockView and change NoValidMailboxesFragment layout #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyDL-Infomaniak
added
the
enhancement
TommyDL-Infomaniak
force-pushed
the
ui/information-block-view
branch
6 times, most recently
from
055753d
to
a00b5c3
Compare
LunarX
requested changes
Jun 6, 2024
app/src/main/java/com/infomaniak/mail/ui/noValidMailboxes/NoValidMailboxesFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/views/InformationBlockView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/views/InformationBlockView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/views/InformationBlockView.kt
Outdated
Show resolved
Hide resolved
LunarX
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Also the title of the PR could be a bit more precise. Your point was not to make the InformationBlockView more configurable but to update the locked mailboxes screen. This, in turn, required the InformationBlockView to be more configurable, but that's not really the main objective of the PR
TommyDL-Infomaniak
changed the title
KevinBoulongne
requested changes
Jun 7, 2024
app/src/main/java/com/infomaniak/mail/ui/noValidMailboxes/NoValidMailboxesFragment.kt
Outdated
Show resolved
Hide resolved
|
This PR/issue depends on: |
TommyDL-Infomaniak
force-pushed
the
ui/information-block-view
branch
2 times, most recently
from
a98575d
to
602b301
Compare
TommyDL-Infomaniak
force-pushed
the
ui/information-block-view
branch
from
602b301
to
705ca88
Compare
KevinBoulongne
force-pushed
the
ui/information-block-view
branch
from
d91c569
to
1a400a2
Compare
LunarX
requested changes
Jun 7, 2024
app/src/main/java/com/infomaniak/mail/views/InformationBlockView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/newMessage/AiEngineChoiceFragment.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
force-pushed
the
ui/information-block-view
branch
from
5cb13e1
to
a4e0ceb
Compare
TommyDL-Infomaniak
force-pushed
the
ui/information-block-view
branch
from
a4e0ceb
to
d149c41
Compare
KevinBoulongne
force-pushed
the
ui/information-block-view
branch
from
d149c41
to
fb7a5cf
Compare
KevinBoulongne
force-pushed
the
ui/information-block-view
branch
from
fb7a5cf
to
ac63c7f
Compare
LunarX
requested changes
Jun 11, 2024
app/src/main/java/com/infomaniak/mail/ui/newMessage/AiEngineChoiceFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/views/InformationBlockView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/views/InformationBlockView.kt
Outdated
Show resolved
Hide resolved
LunarX
approved these changes
Jun 11, 2024
This was referenced Jun 11, 2024
…boxesFragment layout It now has three optional elements: a title, a description, and a button.
KevinBoulongne
force-pushed
the
ui/information-block-view
branch
from
54f7575
to
3b25416
Compare
|
KevinBoulongne
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now has five optional elements: an icon, a title, a description, a button, and a close button.
Depends on Infomaniak/android-core#194