Don't shadow-replace Attachments with the 1st one when forwarding a Message #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
changed the title
FabianDevel
requested changes
Jun 18, 2024
app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt
Outdated
Show resolved
Hide resolved
We are not sure the Attachments in the Edit : finally, we dit it. |
KevinBoulongne
force-pushed
the
fix-forward-attachments
branch
from
4c89a96
to
7853e21
Compare
LunarX
requested changes
Jun 20, 2024
app/src/main/java/com/infomaniak/mail/data/models/Attachment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
force-pushed
the
fix-forward-attachments
branch
from
b2715b1
to
3149360
Compare
KevinBoulongne
changed the base branch from
master
to
uiAttachments-liveData-access
KevinBoulongne
force-pushed
the
fix-forward-attachments
branch
from
ee60cc1
to
7f0b61f
Compare
LunarX
approved these changes
Jun 20, 2024
KevinBoulongne
force-pushed
the
uiAttachments-liveData-access
branch
from
c190f4f
to
374ede4
Compare
KevinBoulongne
force-pushed
the
fix-forward-attachments
branch
from
7f0b61f
to
a82c705
Compare
|
This PR/issue depends on: |
…are in FORWARD mode and the Attachment's list hasn't be touched by the user
This reverts commit 7853e21.
Co-authored-by: Gibran Chevalley <32095402+LunarX@users.noreply.github.com>
…ta()` in its own boolean
KevinBoulongne
force-pushed
the
fix-forward-attachments
branch
from
a82c705
to
47c66fe
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1929
We've got an issue where, when forwarding an email, we replace all of its Attachments with the 1st one that we find.
It was caused by a wrong usage of
uploadLocalUri, that we supposed couldn't benull.The truth was that, when forwarding emails, Attachments don't have any
uploadLocalUri.