Check before trying to refresh messages for a specific mailbox if this one has already been open once #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevincent
force-pushed
the
failed-show-notif-sentry
branch
from
dd9ef85
to
2fb4a33
Compare
sirambd
requested changes
Jul 10, 2024
| fetchMessagesManager.execute(scope = this, user.id, mailbox) | ||
| val mailboxes = mailboxController.getMailboxes(user.id) | ||
| mailboxes.forEach { mailbox -> | ||
| val realm = RealmDatabase.newMailboxContentInstance(user.id, mailbox.mailboxId) |
There was a problem hiding this comment.
I can't see when this realm is closed.
tevincent
force-pushed
the
failed-show-notif-sentry
branch
3 times, most recently
from
d2873a2
to
f2f53b8
Compare
…s one has already been open once
tevincent
force-pushed
the
failed-show-notif-sentry
branch
from
f2f53b8
to
a53af30
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid a huge amount of Sentry logs (
We received a Notification, but we failed to show it) when we try to refresh an unopened mailbox.