chore: PR Feedback

Sources/InfomaniakCore/Asynchronous/ParallelTaskMapper.swift

@@ -30,8 +30,8 @@ public typealias SequenceableCollection = Sequence & Collection
 ///
 @available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)
 public struct ParallelTaskMapper {
-    /// internal processing TaskQueue
-    let taskQueue: TaskQueue
+    /// private processing TaskQueue
+    private let taskQueue: TaskQueue
 
     /// Init function
     /// - Parameter concurrency: execution depth, keep default for optimized threading.

Sources/InfomaniakCore/ClosureKit/CurriedClosure.swift

@@ -19,17 +19,17 @@
 import Foundation
 
 /// Represents `any` (ie. all of them not the type) curried closure, of arbitrary type.
-///
-/// see `AsyncCurriedClosure` if you need support for structured concurrency or error feedback
-@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)
 public typealias CurriedClosure<Input, Output> = (Input) -> Output
 
 /// A closure that take no argument and return nothing, but technically curried.
-@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)
+///
+/// Calling this closure type requires the use of `Void` which is, in swift, an empty tuple `()`.
 public typealias SimpleClosure = CurriedClosure<Void, Void>
 
 /// Append a SimpleClosure to another one
-@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)
+///
+/// This allows you to append / prepend a closure to another one with the + operator.
+/// This is not function composition.
 public func + (_ lhs: @escaping SimpleClosure, _ rhs: @escaping SimpleClosure) -> SimpleClosure {
     let closure: SimpleClosure = { _ in
         lhs(())

Sources/InfomaniakCore/Extensions/Bundle+Extension.swift

@@ -19,6 +19,7 @@
 import Foundation
 
 public extension Bundle {
+    /// Returns `true` if executing in app extension context
     var isExtension: Bool {
         return bundleURL.pathExtension == "appex"
     }

Sources/InfomaniakCore/Extensions/Collection+Safe.swift

@@ -26,6 +26,8 @@ public extension Collection {
 }
 
 public extension Array {
+    /// Returns an `ArraySlice` for the specified indexes if possible.
+    /// The Slice is bounded to the size of the current collection.
     subscript(safe range: Range<Index>) -> ArraySlice<Element> {
         return self[Swift.min(range.startIndex, endIndex) ..< Swift.min(range.endIndex, endIndex)]
     }

Tests/InfomaniakCoreTests/UTCurriedClosure.swift

@@ -19,7 +19,15 @@
 import InfomaniakCore
 import XCTest
 
-@available(macOS 10.15, iOS 13.0, tvOS 13.0, watchOS 6.0, *)
+public final class CountedFulfillmentTestExpectation: XCTestExpectation {
+    private(set) var currentFulfillmentCount = 0
+
+    override public func fulfill() {
+        currentFulfillmentCount += 1
+        super.fulfill()
+    }
+}
+
 final class UTCurriedClosure: XCTestCase {
     func testAppendToClosure() {
         // GIVEN
@@ -41,7 +49,7 @@ final class UTCurriedClosure: XCTestCase {
 
         // WHEN
         let computation = a + b
-        let _ = computation~
+        computation(())
 
         // THEN
         wait(for: expectations, timeout: 10.0)
@@ -77,7 +85,7 @@ final class UTCurriedClosure: XCTestCase {
 
         // WHEN
         let computation = a + b + c
-        let _ = computation~
+        computation(())
 
         // THEN
         wait(for: expectations, timeout: 10.0)