Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sendable collections improvements #52

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

PhilippeWeidmann
Copy link
Member

I chose to not reimplement the whole RangeReplaceableCollection protocol but rather add methods when needed.

@PhilippeWeidmann PhilippeWeidmann force-pushed the sendable-collections-improvements branch from 230d11c to 95cef4f Compare July 21, 2023 10:52
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a small proposal regarding how we check assertions.

Tests/InfomaniakCoreTests/UTCollectionTests.swift Outdated Show resolved Hide resolved
Tests/InfomaniakCoreTests/UTCollectionTests.swift Outdated Show resolved Hide resolved
Tests/InfomaniakCoreTests/UTCollectionTests.swift Outdated Show resolved Hide resolved
@adrien-coye
Copy link
Contributor

adrien-coye commented Jul 21, 2023

Note: Something I do not really like today is the fact SendableCollections are classes (For the record I wrote it this way for convenience). I mean it does work but you can write a let and mutate it, breaking with expected swift collections behaviour. Just saying that might be something else we could improve.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PhilippeWeidmann
Copy link
Member Author

Note: Something I do not really like today is the fact SendableCollections are classes (For the record I wrote it this way for convenience). I mean it does work but you can write a let and mutate it, breaking with expected swift collections behaviour. Just saying that might be something else we could improve.

Yup totally agree

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the code.

@PhilippeWeidmann PhilippeWeidmann merged commit 3df6985 into master Jul 21, 2023
4 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the sendable-collections-improvements branch July 21, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants