Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TolerantDispatchGroup has a hight default QoS preventing most priority inversions. #99

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: TolerantDispatchGroup has a hight default QoS preventing most priority inversions. #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff0aaa
fix: Make sure a TolerantDispatchGroup has a default QoS that prevent…
adrien-coye Jan 31, 2024
baf039b
fix: Fix Unit test failing
adrien-coye Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/InfomaniakCore/Asynchronous/TolerantDispatchGroup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ public final class TolerantDispatchGroup {
private let dispatchGroup = DispatchGroup()
private var callBalancer = 0

public init(qos: DispatchQoS = .default) {
/// Init method of TolerantDispatchGroup
/// - Parameter qos: The QoS of the underlying queue. Default to `.userInitiated` to prevent most priority inversions
public init(qos: DispatchQoS = .userInitiated) {
syncQueue = DispatchQueue(label: "com.infomaniak.TolerantDispatchGroup", qos: qos)
}

Expand Down
4 changes: 2 additions & 2 deletions Tests/InfomaniakCoreTests/UTTolerantDispatchGroup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ final class UTTolerantDispatchGroup: XCTestCase {
XCTAssertNotNil(dispatchGroup)
}

func testPriorityDefault() {
func testDefaultPriorityIsHigh() {
// WHEN
let dispatchGroup = TolerantDispatchGroup()

// THEN
XCTAssertNotNil(dispatchGroup)
XCTAssertEqual(dispatchGroup.syncQueue.qos, DispatchQoS.default, "default constructor should have default priority")
XCTAssertEqual(dispatchGroup.syncQueue.qos, DispatchQoS.userInitiated, "default constructor should have default priority")
}

func testPriorityAnyIsSet() {
Expand Down
Loading