Bringing back abstracted file sharing into kDrive #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
commented
Jul 19, 2023
adrien-coye
commented
Jul 19, 2023
refactor(FileImportHelper): cleaned most of the old code and split file.
…e collection of files
…edited pictures from Photo.app
adrien-coye
force-pushed
the
shareExtensionAbstractCode
branch
from
11444a0
to
1510ca8
Compare
…sset manual import
…_ modificationDate, so editing a picture trigger a new upload
Co-authored-by: Philippe Weidmann <philippe.weidmann@infomaniak.com>
|
Kudos, SonarCloud Quality Gate passed!
|
PhilippeWeidmann
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Bring back the
Corework related to file sharing in this app.Also abstracted the on the fly Heic -> Jpg
hereuse date as default name Coreuse date as default name CoreUIShared file name generation between manual import and PhotoLibraryUploader.
Edited pictures in Photo.app have now a non coliding name.
Details