fix: Make sure to set the UserID early for sentry error tracking #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
APIV3_SetSentryUserIdEarly
branch
from
3a15605
to
4fa94fa
Compare
adrien-coye
force-pushed
the
APIV3_SetSentryUserIdEarly
branch
from
4fa94fa
to
ae7d2a5
Compare
|
PhilippeWeidmann
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Making sure the userId is set early in sentry to track crashes in a useful way. It is now set before Realm has a chance of migrating.
Following the work done in a sister PR on the Mail side
Did non regression tests on app and extension. Did not notice anything.